Commit ef697902 authored Apr 19, 2017 by Arnd Bergmann Committed by Jens Axboe Apr 19, 2017

lightnvm: assume 64-bit lba numbers

The driver uses both u64 and sector_t to refer to offsets, and assigns between the
two. This causes one harmless warning when sector_t is 32-bit:

drivers/lightnvm/pblk-rb.c: In function 'pblk_rb_write_entry_gc':
include/linux/lightnvm.h:215:20: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
drivers/lightnvm/pblk-rb.c:324:22: note: in expansion of macro 'ADDR_EMPTY'

As the driver is already doing this inconsistently, changing the type
won't make it worse and is an easy way to avoid the warning.

Fixes: a4bd217b ("lightnvm: physical block device (pblk) target")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jens Axboe <axboe@fb.com>

parent d0fac025

drivers/lightnvm/pblk.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -119,7 +119,7 @@ struct pblk_w_ctx {
		struct bio_list bios; /* Original bios - used for completion
		* in REQ_FUA, REQ_FLUSH case
		*/
		sector_t lba; /* Logic addr. associated with entry */
		u64 lba; /* Logic addr. associated with entry */
		struct ppa_addr ppa; /* Physic addr. associated with entry */
		int flags; /* Write context flags */
		};

Admin message