Commit ef43bc4f authored Jan 11, 2006 by Jan Kara Committed by Linus Torvalds Jan 11, 2006

[PATCH] reiserfs: fix assertion failure in reiserfs+journaled quotas



Sometimes we call do_journal_end() with t_refcount == 0.  If quota is
turned on and we happen to have some inode with preallocation bad things
happen as we try to use the current handle for quota operations.  Checks
for t_refcount in journal_begin() fail and we Oops.  We raise t_refcount to
make those checks happy.  We should not cause any bad as all the needed
quota blocks should be already attached to the transaction (they were
attached to the transaction when we allocated those preallocation blocks).

Signed-off-by: Jan Kara <jack@suse.cz>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: Chris Mason <mason@suse.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 0c8365ec

fs/reiserfs/journal.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -3925,10 +3925,13 @@ static int do_journal_end(struct reiserfs_transaction_handle *th,
		flush = 1;
		}
		#ifdef REISERFS_PREALLOCATE
		/* quota ops might need to nest, setup the journal_info pointer for them */
		/* quota ops might need to nest, setup the journal_info pointer for them
		* and raise the refcount so that it is > 0. */
		current->journal_info = th;
		th->t_refcount++;
		reiserfs_discard_all_prealloc(th); /* it should not involve new blocks into
		* the transaction */
		th->t_refcount--;
		current->journal_info = th->t_handle_save;
		#endif

Admin message