Commit ef2b22ac authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpuidle / sleep: Use broadcast timer for states that stop local timer 



Commit 38106313 (PM / sleep: Re-implement suspend-to-idle handling)
overlooked the fact that entering some sufficiently deep idle states
by CPUs may cause their local timers to stop and in those cases it
is necessary to switch over to a broadcast timer prior to entering
the idle state.  If the cpuidle driver in use does not provide
the new ->enter_freeze callback for any of the idle states, that
problem affects suspend-to-idle too, but it is not taken into account
after the changes made by commit 38106313.

Fix that by changing the definition of cpuidle_enter_freeze() and
re-arranging of the code in cpuidle_idle_call(), so the former does
not call cpuidle_enter() any more and the fallback case is handled
by cpuidle_idle_call() directly.

Fixes: 38106313 (PM / sleep: Re-implement suspend-to-idle handling)
Reported-and-tested-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
parent dfcacc15

drivers/cpuidle/cpuidle.c

+22 −40
Original line number Original line Diff line number Diff line
@@ -44,7 +44,7 @@ void disable_cpuidle(void) 
	off = 1;

	off = 1;

}

}





static bool cpuidle_not_available(struct cpuidle_driver *drv,

bool cpuidle_not_available(struct cpuidle_driver *drv,

			   struct cpuidle_device *dev)

			   struct cpuidle_device *dev)

{

{

	return off || !initialized || !drv || !dev || !dev->enabled;

	return off || !initialized || !drv || !dev || !dev->enabled;
@@ -72,13 +72,7 @@ int cpuidle_play_dead(void) 
	return -ENODEV;

	return -ENODEV;

}

}





/**

static int find_deepest_state(struct cpuidle_driver *drv,

 * cpuidle_find_deepest_state - Find deepest state meeting specific conditions.

 * @drv: cpuidle driver for the given CPU.

 * @dev: cpuidle device for the given CPU.

 * @freeze: Whether or not the state should be suitable for suspend-to-idle.

 */

static int cpuidle_find_deepest_state(struct cpuidle_driver *drv,

			      struct cpuidle_device *dev, bool freeze)

			      struct cpuidle_device *dev, bool freeze)

{

{

	unsigned int latency_req = 0;

	unsigned int latency_req = 0;
@@ -98,6 +92,17 @@ static int cpuidle_find_deepest_state(struct cpuidle_driver *drv, 
	return ret;

	return ret;

}

}





/**

 * cpuidle_find_deepest_state - Find the deepest available idle state.

 * @drv: cpuidle driver for the given CPU.

 * @dev: cpuidle device for the given CPU.

 */

int cpuidle_find_deepest_state(struct cpuidle_driver *drv,

			       struct cpuidle_device *dev)

{

	return find_deepest_state(drv, dev, false);

}



static void enter_freeze_proper(struct cpuidle_driver *drv,

static void enter_freeze_proper(struct cpuidle_driver *drv,

				struct cpuidle_device *dev, int index)

				struct cpuidle_device *dev, int index)

{

{
@@ -119,46 +124,26 @@ static void enter_freeze_proper(struct cpuidle_driver *drv, 




/**

/**

 * cpuidle_enter_freeze - Enter an idle state suitable for suspend-to-idle.

 * cpuidle_enter_freeze - Enter an idle state suitable for suspend-to-idle.

 * @drv: cpuidle driver for the given CPU.

 * @dev: cpuidle device for the given CPU.

 *

 *

 * If there are states with the ->enter_freeze callback, find the deepest of

 * If there are states with the ->enter_freeze callback, find the deepest of

 * them and enter it with frozen tick.  Otherwise, find the deepest state

 * them and enter it with frozen tick.

 * available and enter it normally.

 *

 * Returns with enabled interrupts.

 */

 */

void cpuidle_enter_freeze(void)

int cpuidle_enter_freeze(struct cpuidle_driver *drv, struct cpuidle_device *dev)

{

{

	struct cpuidle_device *dev = __this_cpu_read(cpuidle_devices);

	struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);

	int index;

	int index;





	if (cpuidle_not_available(drv, dev))

		goto fallback;



	/*

	/*

	 * Find the deepest state with ->enter_freeze present, which guarantees

	 * Find the deepest state with ->enter_freeze present, which guarantees

	 * that interrupts won't be enabled when it exits and allows the tick to

	 * that interrupts won't be enabled when it exits and allows the tick to

	 * be frozen safely.

	 * be frozen safely.

	 */

	 */

	index = cpuidle_find_deepest_state(drv, dev, true);

	index = find_deepest_state(drv, dev, true);

	if (index >= 0) {

	if (index >= 0)

		enter_freeze_proper(drv, dev, index);

		enter_freeze_proper(drv, dev, index);

		local_irq_enable();

		return;

	}





	/*

	return index;

	 * It is not safe to freeze the tick, find the deepest state available

	 * at all and try to enter it normally.

	 */

	index = cpuidle_find_deepest_state(drv, dev, false);

	if (index >= 0) {

		cpuidle_enter(drv, dev, index);

		return;

	}



 fallback:

	arch_cpu_idle();

}

}





/**

/**
@@ -217,9 +202,6 @@ int cpuidle_enter_state(struct cpuidle_device *dev, struct cpuidle_driver *drv, 
 */

 */

int cpuidle_select(struct cpuidle_driver *drv, struct cpuidle_device *dev)

int cpuidle_select(struct cpuidle_driver *drv, struct cpuidle_device *dev)

{

{

	if (cpuidle_not_available(drv, dev))

		return -ENODEV;



	return cpuidle_curr_governor->select(drv, dev);

	return cpuidle_curr_governor->select(drv, dev);

}

}

include/linux/cpuidle.h

+15 −2
Original line number Original line Diff line number Diff line
@@ -126,6 +126,8 @@ struct cpuidle_driver { 




#ifdef CONFIG_CPU_IDLE

#ifdef CONFIG_CPU_IDLE

extern void disable_cpuidle(void);

extern void disable_cpuidle(void);

extern bool cpuidle_not_available(struct cpuidle_driver *drv,

				  struct cpuidle_device *dev);





extern int cpuidle_select(struct cpuidle_driver *drv,

extern int cpuidle_select(struct cpuidle_driver *drv,

			  struct cpuidle_device *dev);

			  struct cpuidle_device *dev);
@@ -150,11 +152,17 @@ extern void cpuidle_resume(void); 
extern int cpuidle_enable_device(struct cpuidle_device *dev);

extern int cpuidle_enable_device(struct cpuidle_device *dev);

extern void cpuidle_disable_device(struct cpuidle_device *dev);

extern void cpuidle_disable_device(struct cpuidle_device *dev);

extern int cpuidle_play_dead(void);

extern int cpuidle_play_dead(void);

extern void cpuidle_enter_freeze(void);

extern int cpuidle_find_deepest_state(struct cpuidle_driver *drv,

				      struct cpuidle_device *dev);

extern int cpuidle_enter_freeze(struct cpuidle_driver *drv,

				struct cpuidle_device *dev);





extern struct cpuidle_driver *cpuidle_get_cpu_driver(struct cpuidle_device *dev);

extern struct cpuidle_driver *cpuidle_get_cpu_driver(struct cpuidle_device *dev);

#else

#else

static inline void disable_cpuidle(void) { }

static inline void disable_cpuidle(void) { }

static inline bool cpuidle_not_available(struct cpuidle_driver *drv,

					 struct cpuidle_device *dev)

{return true; }

static inline int cpuidle_select(struct cpuidle_driver *drv,

static inline int cpuidle_select(struct cpuidle_driver *drv,

				 struct cpuidle_device *dev)

				 struct cpuidle_device *dev)

{return -ENODEV; }

{return -ENODEV; }
@@ -183,7 +191,12 @@ static inline int cpuidle_enable_device(struct cpuidle_device *dev) 
{return -ENODEV; }

{return -ENODEV; }

static inline void cpuidle_disable_device(struct cpuidle_device *dev) { }

static inline void cpuidle_disable_device(struct cpuidle_device *dev) { }

static inline int cpuidle_play_dead(void) {return -ENODEV; }

static inline int cpuidle_play_dead(void) {return -ENODEV; }

static inline void cpuidle_enter_freeze(void) { }

static inline int cpuidle_find_deepest_state(struct cpuidle_driver *drv,

					     struct cpuidle_device *dev)

{return -ENODEV; }

static inline int cpuidle_enter_freeze(struct cpuidle_driver *drv,

				       struct cpuidle_device *dev)

{return -ENODEV; }

static inline struct cpuidle_driver *cpuidle_get_cpu_driver(

static inline struct cpuidle_driver *cpuidle_get_cpu_driver(

	struct cpuidle_device *dev) {return NULL; }

	struct cpuidle_device *dev) {return NULL; }

#endif

#endif

kernel/sched/idle.c

+21 −9
Original line number Original line Diff line number Diff line
@@ -82,6 +82,7 @@ static void cpuidle_idle_call(void) 
	struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);

	struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);

	int next_state, entered_state;

	int next_state, entered_state;

	unsigned int broadcast;

	unsigned int broadcast;

	bool reflect;





	/*

	/*

	 * Check if the idle task must be rescheduled. If it is the

	 * Check if the idle task must be rescheduled. If it is the
@@ -105,6 +106,9 @@ static void cpuidle_idle_call(void) 
	 */

	 */

	rcu_idle_enter();

	rcu_idle_enter();





	if (cpuidle_not_available(drv, dev))

		goto use_default;



	/*

	/*

	 * Suspend-to-idle ("freeze") is a system state in which all user space

	 * Suspend-to-idle ("freeze") is a system state in which all user space

	 * has been frozen, all I/O devices have been suspended and the only

	 * has been frozen, all I/O devices have been suspended and the only
@@ -115,15 +119,22 @@ static void cpuidle_idle_call(void) 
	 * until a proper wakeup interrupt happens.

	 * until a proper wakeup interrupt happens.

	 */

	 */

	if (idle_should_freeze()) {

	if (idle_should_freeze()) {

		cpuidle_enter_freeze();

		entered_state = cpuidle_enter_freeze(drv, dev);

		if (entered_state >= 0) {

			local_irq_enable();

			goto exit_idle;

			goto exit_idle;

		}

		}





		reflect = false;

		next_state = cpuidle_find_deepest_state(drv, dev);

	} else {

		reflect = true;

		/*

		/*

		 * Ask the cpuidle framework to choose a convenient idle state.

		 * Ask the cpuidle framework to choose a convenient idle state.

	 * Fall back to the default arch idle method on errors.

		 */

		 */

		next_state = cpuidle_select(drv, dev);

		next_state = cpuidle_select(drv, dev);

	}

	/* Fall back to the default arch idle method on errors. */

	if (next_state < 0)

	if (next_state < 0)

		goto use_default;

		goto use_default;
@@ -170,6 +181,7 @@ static void cpuidle_idle_call(void) 
	/*

	/*

	 * Give the governor an opportunity to reflect on the outcome

	 * Give the governor an opportunity to reflect on the outcome

	 */

	 */

	if (reflect)

		cpuidle_reflect(dev, entered_state);

		cpuidle_reflect(dev, entered_state);





exit_idle:

exit_idle:

CRA Git | Maintained and supported by SUSTech CRA and CCSE