ubifs: Fix memory leak in lprobs self-check (eef19816) · Commits · 戴 / test

Allocate the buffer after we return early. Otherwise memory is being leaked. Cc: <stable@vger.kernel.org> Fixes: ("UBIFS: add new flash file system") Signed-off-by:

Richard Weinberger <richard@nod.at>

fs/ubifs/lprops.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -1089,10 +1089,6 @@ static int scan_check_cb(struct ubifs_info *c,
		}
		}

		buf = __vmalloc(c->leb_size, GFP_NOFS, PAGE_KERNEL);
		if (!buf)
		return -ENOMEM;

		/*
		* After an unclean unmount, empty and freeable LEBs
		* may contain garbage - do not scan them.
		@@ -1111,6 +1107,10 @@ static int scan_check_cb(struct ubifs_info *c,
		return LPT_SCAN_CONTINUE;
		}

		buf = __vmalloc(c->leb_size, GFP_NOFS, PAGE_KERNEL);
		if (!buf)
		return -ENOMEM;

		sleb = ubifs_scan(c, lnum, 0, buf, 0);
		if (IS_ERR(sleb)) {
		ret = PTR_ERR(sleb);

Admin message