Commit eeeda4cd authored Sep 24, 2014 by Ben Hutchings Committed by Ingo Molnar Sep 24, 2014

x86/relocs: Make per_cpu_load_addr static

per_cpu_load_addr is only used for 64-bit relocations, but is
declared in both configurations of relocs.c - with different
types.  This has undefined behaviour in general.  GNU ld is
documented to use the larger size in this case, but other tools
may differ and some warn about this.

References: https://bugs.debian.org/748577


Reported-by: Michael Tautschnig <mt@debian.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: 748577@bugs.debian.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1411561812.3659.23.camel@decadent.org.uk


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent ce4b1b16

arch/x86/tools/relocs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -695,7 +695,7 @@ static void walk_relocs(int (process)(struct section sec, Elf_Rel *rel,
		*
		*/
		static int per_cpu_shndx = -1;
		Elf_Addr per_cpu_load_addr;
		static Elf_Addr per_cpu_load_addr;

		static void percpu_init(void)
		{

Admin message