Commit eed8c3ee authored by Wei Yongjun's avatar Wei Yongjun Committed by Mauro Carvalho Chehab
Browse files

[media] media: i2c: lm3560: fix missing unlock on error in lm3560_set_ctrl() 



Add the missing unlock before return from function lm3560_set_ctrl()
in the error handling case.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent fe9a2bd8

drivers/media/i2c/lm3560.c

+9 −5
Original line number Diff line number Diff line
@@ -219,15 +219,19 @@ static int lm3560_set_ctrl(struct v4l2_ctrl *ctrl, enum lm3560_led_id led_no) 
		break;



	case V4L2_CID_FLASH_STROBE:

		if (flash->led_mode != V4L2_FLASH_LED_MODE_FLASH)

			return -EBUSY;

		if (flash->led_mode != V4L2_FLASH_LED_MODE_FLASH) {

			rval = -EBUSY;

			goto err_out;

		}

		flash->led_mode = V4L2_FLASH_LED_MODE_FLASH;

		rval = lm3560_mode_ctrl(flash);

		break;



	case V4L2_CID_FLASH_STROBE_STOP:

		if (flash->led_mode != V4L2_FLASH_LED_MODE_FLASH)

			return -EBUSY;

		if (flash->led_mode != V4L2_FLASH_LED_MODE_FLASH) {

			rval = -EBUSY;

			goto err_out;

		}

		flash->led_mode = V4L2_FLASH_LED_MODE_NONE;

		rval = lm3560_mode_ctrl(flash);

		break;
@@ -247,8 +251,8 @@ static int lm3560_set_ctrl(struct v4l2_ctrl *ctrl, enum lm3560_led_id led_no) 
		break;

	}



	mutex_unlock(&flash->lock);

err_out:

	mutex_unlock(&flash->lock);

	return rval;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE