Commit eeca9fce authored by Ilan peer's avatar Ilan peer Committed by Johannes Berg
Browse files

cfg80211: Schedule timeout for all CRDA calls 



Timeout was scheduled only in case CRDA was called due to user hints,
but was not scheduled for other cases. This can result in regulatory
hint processing getting stuck in case that there is no CRDA configured.

Change this by scheduling a timeout every time CRDA is called. In
addition, in restore_regulatory_settings() all pending requests are
restored (and not only the user ones).

Signed-off-by: default avatarIlan Peer <ilan.peer@intel.com>
Acked-by: default avatarLuis R. Rodriguez <mcgrof@suse.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 05050753

net/wireless/reg.c

+5 −10
Original line number Diff line number Diff line
@@ -552,6 +552,9 @@ reg_call_crda(struct regulatory_request *request) 
{

	if (call_crda(request->alpha2))

		return REG_REQ_IGNORE;



	queue_delayed_work(system_power_efficient_wq,

			   &reg_timeout, msecs_to_jiffies(3142));

	return REG_REQ_OK;

}
@@ -1791,7 +1794,6 @@ static void reg_set_request_processed(void) 
		need_more_processing = true;

	spin_unlock(&reg_requests_lock);



	if (lr->initiator == NL80211_REGDOM_SET_BY_USER)

	cancel_delayed_work(&reg_timeout);



	if (need_more_processing)
@@ -2071,8 +2073,6 @@ static void reg_process_hint(struct regulatory_request *reg_request) 
		if (treatment == REG_REQ_IGNORE ||

		    treatment == REG_REQ_ALREADY_SET)

			return;

		queue_delayed_work(system_power_efficient_wq,

				   &reg_timeout, msecs_to_jiffies(3142));

		return;

	case NL80211_REGDOM_SET_BY_DRIVER:

		if (!wiphy)
@@ -2496,7 +2496,6 @@ static void restore_regulatory_settings(bool reset_user) 
	char alpha2[2];

	char world_alpha2[2];

	struct reg_beacon *reg_beacon, *btmp;

	struct regulatory_request *reg_request, *tmp;

	LIST_HEAD(tmp_reg_req_list);

	struct cfg80211_registered_device *rdev;
@@ -2524,11 +2523,7 @@ static void restore_regulatory_settings(bool reset_user) 
	 * settings.

	 */

	spin_lock(&reg_requests_lock);

	list_for_each_entry_safe(reg_request, tmp, &reg_requests_list, list) {

		if (reg_request->initiator != NL80211_REGDOM_SET_BY_USER)

			continue;

		list_move_tail(&reg_request->list, &tmp_reg_req_list);

	}

	list_splice_tail_init(&reg_requests_list, &tmp_reg_req_list);

	spin_unlock(&reg_requests_lock);



	/* Clear beacon hints */

CRA Git | Maintained and supported by SUSTech CRA and CCSE