Commit eec85fa9 authored Jun 11, 2018 by Geert Uytterhoeven Committed by Greg Ungerer Jul 30, 2018

m68k: coldfire: Normalize clk API



Coldfire still provides its own variant of the clk API rather than using
the generic COMMON_CLK API.  This generally works, but it causes some
link errors with drivers using the clk_round_rate(), clk_set_rate(),
clk_set_parent(), or clk_get_parent() functions when a platform lacks
those interfaces.

This adds empty stub implementations for each of them, and I don't even
try to do something useful here but instead just print a WARN() message
to make it obvious what is going on if they ever end up being called.

The drivers that call these won't be used on these platforms (otherwise
we'd get a link error today), so the added code is harmless bloat and
will warn about accidental use.

Based on commit bd7fefe1 ("ARM: w90x900: normalize clk API").

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>

parent acb18725

arch/m68k/coldfire/clk.c

+29 −0

Original line number	Diff line number	Diff line
		@@ -129,4 +129,33 @@ unsigned long clk_get_rate(struct clk *clk)
		}
		EXPORT_SYMBOL(clk_get_rate);

		/* dummy functions, should not be called */
		long clk_round_rate(struct clk *clk, unsigned long rate)
		{
		WARN_ON(clk);
		return 0;
		}
		EXPORT_SYMBOL(clk_round_rate);

		int clk_set_rate(struct clk *clk, unsigned long rate)
		{
		WARN_ON(clk);
		return 0;
		}
		EXPORT_SYMBOL(clk_set_rate);

		int clk_set_parent(struct clk clk, struct clk parent)
		{
		WARN_ON(clk);
		return 0;
		}
		EXPORT_SYMBOL(clk_set_parent);

		struct clk clk_get_parent(struct clk clk)
		{
		WARN_ON(clk);
		return NULL;
		}
		EXPORT_SYMBOL(clk_get_parent);

		/***************************************************************************/

Admin message