Commit eec11535 authored Jan 18, 2017 by Dan Carpenter Committed by Al Viro Feb 18, 2017

hfs: fix hfs_readdir()



I was looking through static analysis warnings and there is a bug here
that goes all the way back to the start of git.  Basically we're copying
the pointer and nearby garbage instead of the data the fd.key pointer is
pointing to.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Vyacheslav Dubeyko <slava@dubeyko.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent b8826e50

fs/hfs/dir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -169,7 +169,7 @@ static int hfs_readdir(struct file file, struct dir_context ctx)
		* Can be done after the list insertion; exclusion with
		* hfs_delete_cat() is provided by directory lock.
		*/
		memcpy(&rd->key, &fd.key, sizeof(struct hfs_cat_key));
		memcpy(&rd->key, &fd.key->cat, sizeof(struct hfs_cat_key));
		out:
		hfs_find_exit(&fd);
		return err;

Admin message