Commit eea3f891 authored Aug 03, 2006 by Juha Yrjl Committed by Greg Kroah-Hartman Sep 25, 2006

sysfs: Make poll behaviour consistent



When no events have been reported by sysfs_notify(), sd->s_events
was previously set to zero.  The initial value for new readers is
also zero, so poll was blocking, regardless of whether the attribute
was read by the process or not.

Make poll behave consistently by setting the initial value of
sd->s_events to non-zero.

Signed-off-by: Juha Yrjola <juha.yrjola@solidboot.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent ab7d7371

fs/sysfs/dir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -43,7 +43,7 @@ static struct sysfs_dirent * sysfs_new_dirent(struct sysfs_dirent * parent_sd,

		memset(sd, 0, sizeof(*sd));
		atomic_set(&sd->s_count, 1);
		atomic_set(&sd->s_event, 0);
		atomic_set(&sd->s_event, 1);
		INIT_LIST_HEAD(&sd->s_children);
		list_add(&sd->s_sibling, &parent_sd->s_children);
		sd->s_element = element;

Admin message