s390/mm: flush tlb of shadows in all situations (eea3678d) · Commits · 戴 / test

For now, the tlb of shadow gmap is only flushed when the parent is removed, not when it is removed upfront. Therefore other shadow gmaps can reuse the tables without the tlb getting flushed. Fix this by simply flushing the tlb 1. Before the shadow tables are removed (analogouos to other unshadow functions) 2. When the gmap is freed and therefore the top level pages are freed. Acked-by:

Martin Schwidefsky <schwidefsky@de.ibm.com> Signed-off-by:

David Hildenbrand <dahi@linux.vnet.ibm.com> Signed-off-by:

Christian Borntraeger <borntraeger@de.ibm.com>

arch/s390/mm/gmap.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -173,6 +173,9 @@ static void gmap_free(struct gmap *gmap)
		{
		struct page page, next;

		/* Flush tlb of all gmaps (if not already done for shadows) */
		if (!(gmap_is_shadow(gmap) && gmap->removed))
		gmap_flush_tlb(gmap);
		/* Free all segment & region tables. */
		list_for_each_entry_safe(page, next, &gmap->crst_list, lru)
		__free_pages(page, 2);
		@@ -226,13 +229,10 @@ void gmap_remove(struct gmap *gmap)
		{
		struct gmap sg, next;

		/* Flush tlb. */
		gmap_flush_tlb(gmap);
		/* Remove all shadow gmaps linked to this gmap */
		if (!list_empty(&gmap->children)) {
		spin_lock(&gmap->shadow_lock);
		list_for_each_entry_safe(sg, next, &gmap->children, list) {
		gmap_flush_tlb(sg);
		list_del(&sg->list);
		gmap_put(sg);
		}
		@@ -1360,6 +1360,7 @@ static void gmap_unshadow(struct gmap *sg)
		return;
		sg->removed = 1;
		gmap_call_notifier(sg, 0, -1UL);
		gmap_flush_tlb(sg);
		table = (unsigned long *)(sg->asce & _ASCE_ORIGIN);
		switch (sg->asce & _ASCE_TYPE_MASK) {
		case _ASCE_TYPE_REGION1:

Admin message