Commit ee98f473 authored Jan 09, 2013 by Johan Hedberg Committed by Gustavo Padovan Jan 10, 2013

Bluetooth: Fix accepting set_dev_class for non-BR/EDR controllers



The concept of Class of Device only exists for BR/EDR controllers. The
mgmt_set_dev_class command should therefore return a proper "not
supported" error if it is attempted for a controller that doesn't
support BR/EDR (e.g. a single mode LE-only one).

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

parent 575b3a02

net/bluetooth/mgmt.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -1424,6 +1424,12 @@ static int set_dev_class(struct sock sk, struct hci_dev hdev, void *data,

		hci_dev_lock(hdev);

		if (!lmp_bredr_capable(hdev)) {
		err = cmd_status(sk, hdev->id, MGMT_OP_SET_DEV_CLASS,
		MGMT_STATUS_NOT_SUPPORTED);
		goto unlock;
		}

		if (test_bit(HCI_PENDING_CLASS, &hdev->dev_flags)) {
		err = cmd_status(sk, hdev->id, MGMT_OP_SET_DEV_CLASS,
		MGMT_STATUS_BUSY);

Admin message