Commit ee915927 authored Aug 16, 2012 by Saul St. John Committed by John W. Linville Sep 07, 2012

bcma: don't leak memory for PCIE, MIPS, GBIT cores



bcma_scan_bus allocates a bcma_core for each core found on the bus, but the
memory for cores handled by the bcma driver itself was not being freed when
the bus was unregistered. This patch adds special handling for the PCIE,
MIPS, and GBIT COMMON cores, to ensure that their memory allocation is
freed as well.

Note that this patch doesn't address the memory allocated for the CC core,
as that was corrected in my previous patch "bcma: register cc core driver,
device."

Cc: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: Saul St. John <saul.stjohn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 03747377

drivers/bcma/main.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -227,7 +227,17 @@ int __devinit bcma_bus_register(struct bcma_bus *bus)

		void bcma_bus_unregister(struct bcma_bus *bus)
		{
		struct bcma_device *cores[3];

		cores[0] = bcma_find_core(bus, BCMA_CORE_MIPS_74K);
		cores[1] = bcma_find_core(bus, BCMA_CORE_PCIE);
		cores[2] = bcma_find_core(bus, BCMA_CORE_4706_MAC_GBIT_COMMON);

		bcma_unregister_cores(bus);

		kfree(cores[2]);
		kfree(cores[1]);
		kfree(cores[0]);
		}

		int __init bcma_bus_early_register(struct bcma_bus *bus,

Admin message