Commit ee8d2267 authored Apr 26, 2020 by Christophe JAILLET Committed by David S. Miller Apr 30, 2020

net: moxa: Fix a potential double 'free_irq()'



Should an irq requested with 'devm_request_irq' be released explicitly,
it should be done by 'devm_free_irq()', not 'free_irq()'.

Fixes: 6c821bd9 ("net: Add MOXA ART SoCs ethernet driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ab046a5d

drivers/net/ethernet/moxa/moxart_ether.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -564,7 +564,7 @@ static int moxart_remove(struct platform_device *pdev)
		struct net_device *ndev = platform_get_drvdata(pdev);

		unregister_netdev(ndev);
		free_irq(ndev->irq, ndev);
		devm_free_irq(&pdev->dev, ndev->irq, ndev);
		moxart_mac_free_memory(ndev);
		free_netdev(ndev);

Admin message