Commit ee75d95c authored by Jon Hunter's avatar Jon Hunter Committed by Paul Walmsley
Browse files

ARM: OMAP2+: PMU: Convert OMAP2/3 devices to use HWMOD 



Convert OMAP2/3 devices to use HWMOD for creating a PMU device. To support PMU
on OMAP2 devices we only need to use MPU sub-system and so we can simply use
the MPU HWMOD to create the PMU device. To support PMU on OMAP3 devices, we need
to use the MPU and DEBUG sub-systems and so use these HWMODs to create the PMU
device for OMAP3.

The MPU HWMOD for OMAP2/3 devices is currently missing the PMU interrupt and so
add the PMU interrupt to the MPU HWMOD for these devices.

This change also moves the PMU code out of the mach-omap2/devices.c files into
its own pmu.c file as suggested by Kevin Hilman to de-clutter devices.c.

Cc: Ming Lei <ming.lei@canonical.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>
Cc: Kevin Hilman <khilman@ti.com>
Signed-off-by: default avatarJon Hunter <jon-hunter@ti.com>
[paul@pwsan.com: fixed checkpatch messages; updated to apply; dropped old-style
 initial filename line in header comments]
Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
parent c7dad45f

arch/arm/mach-omap2/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -199,6 +199,7 @@ obj-$(CONFIG_ARCH_OMAP4) += omap_hwmod_44xx_data.o 


# EMU peripherals

obj-$(CONFIG_OMAP3_EMU)			+= emu.o

obj-$(CONFIG_HW_PERF_EVENTS)		+= pmu.o



# L3 interconnect

obj-$(CONFIG_ARCH_OMAP3)		+= omap_l3_smx.o

arch/arm/mach-omap2/devices.c

+0 −29
Original line number Diff line number Diff line
@@ -434,34 +434,6 @@ static void omap_init_mcspi(void) 
static inline void omap_init_mcspi(void) {}

#endif



static struct resource omap2_pmu_resource = {

	.start	= 3 + OMAP_INTC_START,

	.flags	= IORESOURCE_IRQ,

};



static struct resource omap3_pmu_resource = {

	.start	= 3 + OMAP_INTC_START,

	.flags	= IORESOURCE_IRQ,

};



static struct platform_device omap_pmu_device = {

	.name		= "arm-pmu",

	.id		= ARM_PMU_DEVICE_CPU,

	.num_resources	= 1,

};



static void omap_init_pmu(void)

{

	if (cpu_is_omap24xx())

		omap_pmu_device.resource = &omap2_pmu_resource;

	else if (cpu_is_omap34xx())

		omap_pmu_device.resource = &omap3_pmu_resource;

	else

		return;



	platform_device_register(&omap_pmu_device);

}



/**

 * omap_init_rng - bind the RNG hwmod to the RNG omap_device

 *
@@ -664,7 +636,6 @@ static int __init omap2_init_devices(void) 
		omap_init_mcpdm();

		omap_init_mcspi();

	}

	omap_init_pmu();

	omap_init_sti();

	omap_init_rng();

	omap_init_sham();

arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c

+6 −0
Original line number Diff line number Diff line
@@ -218,8 +218,14 @@ struct omap_hwmod omap2xxx_l4_wkup_hwmod = { 
};



/* MPU */

static struct omap_hwmod_irq_info omap2xxx_mpu_irqs[] = {

	{ .name = "pmu", .irq = 3 },

	{ .irq = -1 }

};



struct omap_hwmod omap2xxx_mpu_hwmod = {

	.name		= "mpu",

	.mpu_irqs	= omap2xxx_mpu_irqs,

	.class		= &mpu_hwmod_class,

	.main_clk	= "mpu_ck",

};

arch/arm/mach-omap2/omap_hwmod_3xxx_data.c

+6 −0
Original line number Diff line number Diff line
@@ -93,8 +93,14 @@ static struct omap_hwmod omap3xxx_l4_sec_hwmod = { 
};



/* MPU */

static struct omap_hwmod_irq_info omap3xxx_mpu_irqs[] = {

	{ .name = "pmu", .irq = 3 },

	{ .irq = -1 }

};



static struct omap_hwmod omap3xxx_mpu_hwmod = {

	.name		= "mpu",

	.mpu_irqs	= omap3xxx_mpu_irqs,

	.class		= &mpu_hwmod_class,

	.main_clk	= "arm_fck",

};

arch/arm/mach-omap2/pmu.c

0 → 100644
+82 −0
Original line number Diff line number Diff line 
/*

 * OMAP2 ARM Performance Monitoring Unit (PMU) Support

 *

 * Copyright (C) 2012 Texas Instruments, Inc.

 *

 * Contacts:

 * Jon Hunter <jon-hunter@ti.com>

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License as published by

 * the Free Software Foundation; either version 2 of the License, or

 * (at your option) any later version.

 */



#include <asm/pmu.h>



#include <plat/omap_hwmod.h>

#include <plat/omap_device.h>



static char *omap2_pmu_oh_names[] = {"mpu"};

static char *omap3_pmu_oh_names[] = {"mpu", "debugss"};

static struct platform_device *omap_pmu_dev;



/**

 * omap2_init_pmu - creates and registers PMU platform device

 * @oh_num:	Number of OMAP HWMODs required to create PMU device

 * @oh_names:	Array of OMAP HWMODS names required to create PMU device

 *

 * Uses OMAP HWMOD framework to create and register an ARM PMU device

 * from a list of HWMOD names passed. Currently supports OMAP2 and

 * OMAP3 devices.

 */

static int __init omap2_init_pmu(unsigned oh_num, char *oh_names[])

{

	int i;

	struct omap_hwmod *oh[2];

	char *dev_name = "arm-pmu";



	if ((!oh_num) || (oh_num > 2))

		return -EINVAL;



	for (i = 0; i < oh_num; i++) {

		oh[i] = omap_hwmod_lookup(oh_names[i]);

		if (!oh[i]) {

			pr_err("Could not look up %s hwmod\n", oh_names[i]);

			return -ENODEV;

		}

	}



	omap_pmu_dev = omap_device_build_ss(dev_name, -1, oh, oh_num, NULL, 0,

					    NULL, 0, 0);

	WARN(IS_ERR(omap_pmu_dev), "Can't build omap_device for %s.\n",

	     dev_name);



	return IS_ERR(omap_pmu_dev) ? PTR_ERR(omap_pmu_dev) : 0;

}



static int __init omap_init_pmu(void)

{

	unsigned oh_num;

	char **oh_names;



	/*

	 * To create an ARM-PMU device the following HWMODs

	 * are required for the various OMAP2+ devices.

	 *

	 * OMAP24xx:	mpu

	 * OMAP3xxx:	mpu, debugss

	 */

	if (cpu_is_omap24xx()) {

		oh_num = ARRAY_SIZE(omap2_pmu_oh_names);

		oh_names = omap2_pmu_oh_names;

	} else if (cpu_is_omap34xx()) {

		oh_num = ARRAY_SIZE(omap3_pmu_oh_names);

		oh_names = omap3_pmu_oh_names;

	} else {

		return 0;

	}



	return omap2_init_pmu(oh_num, oh_names);

}

subsys_initcall(omap_init_pmu);

CRA Git | Maintained and supported by SUSTech CRA and CCSE