Btrfs: fix btrfs_destroy_marked_extents (ee670f0a) · Commits · 戴 / test

So we're forcing the eb's to have their ref count set to 1 so invalidatepage works but this breaks lots of things, for example root nodes, and is just plain wrong, we don't need to just evict all of this stuff. Also drop the invalidatepage altogether and add a page_cache_release(). With this patch we no longer hang when trying to access the root nodes after an aborted transaction and we no longer leak memory. Thanks, Signed-off-by:

Josef Bacik <josef@redhat.com>

fs/btrfs/disk-io.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -3524,11 +3524,9 @@ static int btrfs_destroy_marked_extents(struct btrfs_root *root,
		&(&BTRFS_I(page->mapping->host)->io_tree)->buffer,
		offset >> PAGE_CACHE_SHIFT);
		spin_unlock(&dirty_pages->buffer_lock);
		if (eb) {
		if (eb)
		ret = test_and_clear_bit(EXTENT_BUFFER_DIRTY,
		&eb->bflags);
		atomic_set(&eb->refs, 1);
		}
		if (PageWriteback(page))
		end_page_writeback(page);

		@@ -3542,8 +3540,8 @@ static int btrfs_destroy_marked_extents(struct btrfs_root *root,
		spin_unlock_irq(&page->mapping->tree_lock);
		}

		page->mapping->a_ops->invalidatepage(page, 0);
		unlock_page(page);
		page_cache_release(page);
		}
		}

Admin message