Commit ee6625a9 authored Jan 26, 2017 by Trond Myklebust

pNFS: Fix a reference leak in _pnfs_return_layout



IF NFS_LAYOUT_RETURN_REQUESTED is not set, then we currently exit
without freeing the list of invalidated layout segments, leading
to a reference leak.

Reported-by: Olga Kornievskaia <aglo@umich.edu>
Fixes: 24408f52 ("pNFS: Fix bugs in _pnfs_return_layout")
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

parent 406dab84

fs/nfs/pnfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1200,10 +1200,10 @@ _pnfs_return_layout(struct inode *ino)

		send = pnfs_prepare_layoutreturn(lo, &stateid, NULL);
		spin_unlock(&ino->i_lock);
		pnfs_free_lseg_list(&tmp_list);
		if (send)
		status = pnfs_send_layoutreturn(lo, &stateid, IOMODE_ANY, true);
		out_put_layout_hdr:
		pnfs_free_lseg_list(&tmp_list);
		pnfs_put_layout_hdr(lo);
		out:
		dprintk("<-- %s status: %d\n", __func__, status);

Admin message