Commit ee65e182 authored by Dan Carpenter's avatar Dan Carpenter Committed by Tomi Valkeinen
Browse files

fb: adv7393: off by one in probe function 



This should be >= instead of >.  It's a little bit clearer if we just
get rid of the temporary variable and just use ARRAY_SIZE() directly.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent d4b9efa3

drivers/video/fbdev/bfin_adv7393fb.c

+1 −2
Original line number Diff line number Diff line
@@ -375,7 +375,6 @@ static int bfin_adv7393_fb_probe(struct i2c_client *client, 
{

	int ret = 0;

	struct proc_dir_entry *entry;

	int num_modes = ARRAY_SIZE(known_modes);



	struct adv7393fb_device *fbdev = NULL;
@@ -384,7 +383,7 @@ static int bfin_adv7393_fb_probe(struct i2c_client *client, 
		return -EINVAL;

	}



	if (mode > num_modes) {

	if (mode >= ARRAY_SIZE(known_modes)) {

		dev_err(&client->dev, "mode %d: not supported", mode);

		return -EFAULT;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE