Commit ee61abb3 authored Jan 20, 2013 by Linus Torvalds

module: fix missing module_mutex unlock



Commit 1fb9341a ("module: put modules in list much earlier") moved
some of the module initialization code around, and in the process
changed the exit paths too.  But for the duplicate export symbol error
case the change made the ddebug_cleanup path jump to after the module
mutex unlock, even though it happens with the mutex held.

Rusty has some patches to split this function up into some helper
functions, hopefully the mess of complex goto targets will go away
eventually.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 22636476

kernel/module.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3274,8 +3274,8 @@ again:
		/* module_bug_cleanup needs module_mutex protection */
		mutex_lock(&module_mutex);
		module_bug_cleanup(mod);
		mutex_unlock(&module_mutex);
		ddebug_cleanup:
		mutex_unlock(&module_mutex);
		dynamic_debug_remove(info->debug);
		synchronize_sched();
		kfree(mod->args);

Admin message