Commit ee60b2c5 authored Feb 11, 2014 by Eiichi Tsukata Committed by James Bottomley Mar 15, 2014

[SCSI] Add timeout to avoid infinite command retry

Currently, scsi error handling in scsi_io_completion() tries to
unconditionally requeue scsi command when device keeps some error state.
For example, UNIT_ATTENTION causes infinite retry with
action == ACTION_RETRY.
This is because retryable errors are thought to be temporary and the scsi
device will soon recover from those errors. Normally, such retry policy is
appropriate because the device will soon recover from temporary error state.

But there is no guarantee that device is able to recover from error state
immediately. Some hardware error can prevent device from recovering.

This patch adds timeout in scsi_io_completion() to avoid infinite command
retry in scsi_io_completion(). Once scsi command retry time is longer than
this timeout, the command is treated as failure.

Signed-off-by: Eiichi Tsukata <eiichi.tsukata.xh@hitachi.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

parent eee2b5c8

drivers/scsi/scsi_lib.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -788,6 +788,7 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
		enum {ACTION_FAIL, ACTION_REPREP, ACTION_RETRY,
		ACTION_DELAYED_RETRY} action;
		char *description = NULL;
		unsigned long wait_for = (cmd->allowed + 1) * req->timeout;

		if (result) {
		sense_valid = scsi_command_normalize_sense(cmd, &sshdr);
		@@ -989,6 +990,12 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
		action = ACTION_FAIL;
		}

		if (action != ACTION_FAIL &&
		time_before(cmd->jiffies_at_alloc + wait_for, jiffies)) {
		action = ACTION_FAIL;
		description = "Command timed out";
		}

		switch (action) {
		case ACTION_FAIL:
		/* Give up and fail the remainder of the request */

Admin message