Unverified Commit ee586622 authored May 15, 2020 by Pierre-Louis Bossart Committed by Mark Brown May 18, 2020

ASoC: codecs: rt1308-sdw: remove duplicate allocation



The .read_prop callback is supposed to be called by the SoundWire core
only. Calling it again from this driver results in an additional
memory allocation for no good reason.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Cc: Oder Chiou <oder_chiou@realtek.com>
Cc: Shuming Fan <shumingf@realtek.com>
Cc: Jack Yu <jack.yu@realtek.com>
Link: https://lore.kernel.org/r/20200515211531.11416-4-pierre-louis.bossart@linux.intel.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 07b542fe

sound/soc/codecs/rt1308-sdw.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -178,10 +178,6 @@ static int rt1308_io_init(struct device dev, struct sdw_slave slave)
		if (rt1308->hw_init)
		return 0;

		ret = rt1308_read_prop(slave);
		if (ret < 0)
		goto _io_init_err_;

		if (rt1308->first_hw_init) {
		regcache_cache_only(rt1308->regmap, false);
		regcache_cache_bypass(rt1308->regmap, true);
		@@ -282,7 +278,6 @@ static int rt1308_io_init(struct device dev, struct sdw_slave slave)

		dev_dbg(&slave->dev, "%s hw_init complete\n", __func__);

		_io_init_err_:
		return ret;
		}

Admin message