Unverified Commit ee4ad5d0 authored Nov 10, 2020 by Eddie James Committed by Mark Brown Nov 11, 2020

spi: fsi: Fix transfer returning without finalizing message



In the case that the SPI mux isn't set, the transfer_one_message
function returns without finalizing the message. This means that
the transfer never completes, resulting in hung tasks and an
eventual kernel panic. Fix it by finalizing the transfer in this
case.

Fixes: 9211a441 ("spi: fsi: Check mux status before transfers")
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Link: https://lore.kernel.org/r/20201110214736.25718-1-eajames@linux.ibm.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 766c6b63

drivers/spi/spi-fsi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -477,7 +477,7 @@ static int fsi_spi_transfer_one_message(struct spi_controller *ctlr,

		rc = fsi_spi_check_mux(ctx->fsi, ctx->dev);
		if (rc)
		return rc;
		goto error;

		list_for_each_entry(transfer, &mesg->transfers, transfer_list) {
		struct fsi_spi_sequence seq;

Admin message