perf probe: Use skip_spaces() for argv handling (ee44b5b5) · Commits · 戴 / test

The skip_sep() routine has the same implementation as skip_spaces(), recently adopted from the kernel, sources, switch to it. Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Link: https://lkml.kernel.org/n/tip-0ix211a81z2016dl5nmtdci4@git.kernel.org Signed-off-by:

Arnaldo Carvalho de Melo <acme@redhat.com>

tools/perf/util/string.c

+2 −14

Original line number	Diff line number	Diff line
		@@ -69,18 +69,6 @@ out_err:
		return -1;
		}

		/*
		* Helper function for splitting a string into an argv-like array.
		* originally copied from lib/argv_split.c
		*/
		static const char skip_sep(const char cp)
		{
		while (cp && isspace(cp))
		cp++;

		return cp;
		}

		static const char skip_arg(const char cp)
		{
		while (cp && !isspace(cp))
		@@ -94,7 +82,7 @@ static int count_argc(const char *str)
		int count = 0;

		while (*str) {
		str = skip_sep(str);
		str = skip_spaces(str);
		if (*str) {
		count++;
		str = skip_arg(str);
		@@ -148,7 +136,7 @@ char *argv_split(const char str, int *argcp)
		argvp = argv;

		while (*str) {
		str = skip_sep(str);
		str = skip_spaces(str);

		if (*str) {
		const char *p = str;

Admin message