Commit ee410f15 authored Jun 14, 2018 by Thierry Escande Committed by Linus Torvalds Jun 15, 2018

lib/test_printf.c: call wait_for_random_bytes() before plain %p tests

If the test_printf module is loaded before the crng is initialized, the
plain 'p' tests will fail because the printed address will not be hashed
and the buffer will contain '(ptrval)' instead.

This patch adds a call to wait_for_random_bytes() before plain 'p' tests
to make sure the crng is initialized.

Link: http://lkml.kernel.org/r/20180604113708.11554-1-thierry.escande@linaro.org


Signed-off-by: Thierry Escande <thierry.escande@linaro.org>
Acked-by: Tobin C. Harding <me@tobin.cc>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 608dbdfb

lib/test_printf.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -260,6 +260,13 @@ plain(void)
		{
		int err;

		/*
		* Make sure crng is ready. Otherwise we get "(ptrval)" instead
		* of a hashed address when printing '%p' in plain_hash() and
		* plain_format().
		*/
		wait_for_random_bytes();

		err = plain_hash();
		if (err) {
		pr_warn("plain 'p' does not appear to be hashed\n");

Admin message