Commit ee2555b6 authored Oct 25, 2019 by Arnaldo Carvalho de Melo

perf map: Check if the map still has some refcounts on exit

We were checking just if it was still on some rb tree, but that is not
the only way that this map can still have references, map->refcnt is
there exactly for this, use it.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-hany65tbeavsax7n3xvwl9pc@git.kernel.org

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent b86a9d91

tools/perf/util/map.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -288,7 +288,7 @@ bool map__has_symbols(const struct map *map)

		static void map__exit(struct map *map)
		{
		BUG_ON(!RB_EMPTY_NODE(&map->rb_node));
		BUG_ON(refcount_read(&map->refcnt) != 0);
		dso__zput(map->dso);
		}

Admin message