Commit ee1b5b16 authored Sep 24, 2014 by Bryan O'Donoghue Committed by Ingo Molnar Sep 24, 2014

x86/intel/quark: Switch off CR4.PGE so TLB flush uses CR3 instead



Quark x1000 advertises PGE via the standard CPUID method
PGE bits exist in Quark X1000's PTEs. In order to flush
an individual PTE it is necessary to reload CR3 irrespective
of the PTE.PGE bit.

See Quark Core_DevMan_001.pdf section 6.4.11

This bug was fixed in Galileo kernels, unfixed vanilla kernels are expected to
crash and burn on this platform.

Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Cc: Borislav Petkov <bp@alien8.de>
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/1411514784-14885-1-git-send-email-pure.logic@nexus-software.ie


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent ed2226bd

arch/x86/kernel/cpu/intel.c

+15 −0

Original line number	Diff line number	Diff line
		@@ -144,6 +144,21 @@ static void early_init_intel(struct cpuinfo_x86 *c)
		setup_clear_cpu_cap(X86_FEATURE_ERMS);
		}
		}

		/*
		* Intel Quark Core DevMan_001.pdf section 6.4.11
		* "The operating system also is required to invalidate (i.e., flush)
		* the TLB when any changes are made to any of the page table entries.
		* The operating system must reload CR3 to cause the TLB to be flushed"
		*
		* As a result cpu_has_pge() in arch/x86/include/asm/tlbflush.h should
		* be false so that __flush_tlb_all() causes CR3 insted of CR4.PGE
		* to be modified
		*/
		if (c->x86 == 5 && c->x86_model == 9) {
		pr_info("Disabling PGE capability bit\n");
		setup_clear_cpu_cap(X86_FEATURE_PGE);
		}
		}

		#ifdef CONFIG_X86_32

Admin message