mtd: rawnand: ams-delta: Drop useless local variable (edfd8d9c) · Commits · 戴 / test

For consistency with adjacent code patterns used in the driver probe function, store data GPIO array pointer directly in a respective field of the driver private structure instead of storing it intermediately in a local variable for error checking. Signed-off-by:

Janusz Krzysztofik <jmkrzyszt@gmail.com> Signed-off-by:

Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20200212003929.6682-13-jmkrzyszt@gmail.com

drivers/mtd/nand/raw/ams-delta.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -230,7 +230,6 @@ static int ams_delta_init(struct platform_device *pdev)
		struct ams_delta_nand *priv;
		struct nand_chip *this;
		struct mtd_info *mtd;
		struct gpio_descs *data_gpiods;
		int (probe)(struct platform_device pdev, struct ams_delta_nand *priv);
		int err = 0;

		@@ -312,13 +311,12 @@ static int ams_delta_init(struct platform_device *pdev)
		}

		/* Request array of data pins, initialize them as input */
		data_gpiods = devm_gpiod_get_array(&pdev->dev, "data", GPIOD_IN);
		if (IS_ERR(data_gpiods)) {
		err = PTR_ERR(data_gpiods);
		priv->data_gpiods = devm_gpiod_get_array(&pdev->dev, "data", GPIOD_IN);
		if (IS_ERR(priv->data_gpiods)) {
		err = PTR_ERR(priv->data_gpiods);
		dev_err(&pdev->dev, "data GPIO request failed: %d\n", err);
		return err;
		}
		priv->data_gpiods = data_gpiods;
		priv->data_in = true;

		if (pdev->id_entry)

Admin message