Commit eddf016b authored Oct 17, 2018 by Nikolay Aleksandrov Committed by David S. Miller Oct 17, 2018

net: ipmr: fix unresolved entry dumps



If the skb space ends in an unresolved entry while dumping we'll miss
some unresolved entries. The reason is due to zeroing the entry counter
between dumping resolved and unresolved mfc entries. We should just
keep counting until the whole table is dumped and zero when we move to
the next as we have a separate table counter.

Reported-by: Colin Ian King <colin.king@canonical.com>
Fixes: 8fb472c0 ("ipmr: improve hash scalability")
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 06a36ecb

net/ipv4/ipmr_base.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -296,8 +296,6 @@ int mr_rtm_dumproute(struct sk_buff skb, struct netlink_callback cb,
		next_entry:
		e++;
		}
		e = 0;
		s_e = 0;

		spin_lock_bh(lock);
		list_for_each_entry(mfc, &mrt->mfc_unres_queue, list) {

Admin message