Commit edde82b6 authored Mar 05, 2019 by Peng Wang Committed by Linus Torvalds Mar 05, 2019

mm/slub.c: freelist is ensured to be NULL when new_slab() fails

new_slab_objects() will return immediately if freelist is not NULL.

         if (freelist)
                 return freelist;

One more assignment operation could be avoided.

Link: http://lkml.kernel.org/r/20181229062512.30469-1-rocking@whu.edu.cn


Signed-off-by: Peng Wang <rocking@whu.edu.cn>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 5704a068

mm/slub.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -2482,8 +2482,7 @@ static inline void new_slab_objects(struct kmem_cache s, gfp_t flags,
		stat(s, ALLOC_SLAB);
		c->page = page;
		*pc = c;
		} else
		freelist = NULL;
		}

		return freelist;
		}

Admin message