Commit edd66086 authored Mar 11, 2020 by Takashi Iwai Committed by Rafael J. Wysocki Mar 14, 2020

ACPI: PCI: Use scnprintf() for avoiding potential buffer overflow



Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit.  Fix it by replacing with scnprintf().

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 2c523b34

drivers/acpi/pci_root.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -153,7 +153,7 @@ static void decode_osc_bits(struct acpi_pci_root root, char msg, u32 word,
		buf[0] = '\0';
		for (i = 0, entry = table; i < size; i++, entry++)
		if (word & entry->bit)
		len += snprintf(buf + len, sizeof(buf) - len, "%s%s",
		len += scnprintf(buf + len, sizeof(buf) - len, "%s%s",
		len ? " " : "", entry->desc);

		dev_info(&root->device->dev, "_OSC: %s [%s]\n", msg, buf);

Admin message