Commit edc649a8 authored Sep 18, 2020 by Mathias Nyman Committed by Greg Kroah-Hartman Sep 20, 2020

xhci: Tune interrupt blocking for isochronous transfers

controllers with XHCI_AVOID_BEI quirk cause too frequent interrupts
and affect power management.

To avoid interrupting on every isochronous interval the BEI (Block
Event Interrupt) flag is set for all except the last Isoch TRB in a URB.
This lead to event ring filling up in case several isoc URB were
queued and cancelled rapidly, which some controllers didn't
handle well, and thus the XHCI_AVOID_BEI quirk was introduced.
see commit 227a4fd8 ("usb: xhci: apply XHCI_AVOID_BEI quirk to all
Intel xHCI controllers")

With the XHCI_AVOID_BEI quirk each Isoch TRB will trigger an interrupt.
This can cause up to 8000 interrupts per second for isochronous transfers
with HD USB3 cameras, affecting power saving.

The event ring fits 256 events, instead of interrupting on every
isochronous TRB if XHCI_AVOID_BEI is set we make sure at least every
8th Isochronous TRB asserts an interrupt, clearing the event ring.

Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20200918131752.16488-9-mathias.nyman@linux.intel.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 18a367e8

drivers/usb/host/xhci-ring.c

+19 −4

Original line number	Diff line number	Diff line
		@@ -3736,6 +3736,24 @@ static int xhci_get_isoc_frame_id(struct xhci_hcd *xhci,
		return start_frame;
		}

		/* Check if we should generate event interrupt for a TD in an isoc URB */
		static bool trb_block_event_intr(struct xhci_hcd *xhci, int num_tds, int i)
		{
		if (xhci->hci_version < 0x100)
		return false;
		/* always generate an event interrupt for the last TD */
		if (i == num_tds - 1)
		return false;
		/*
		* If AVOID_BEI is set the host handles full event rings poorly,
		* generate an event at least every 8th TD to clear the event ring
		*/
		if (i && xhci->quirks & XHCI_AVOID_BEI)
		return !!(i % 8);

		return true;
		}

		/* This is for isoc transfer */
		static int xhci_queue_isoc_tx(struct xhci_hcd *xhci, gfp_t mem_flags,
		struct urb *urb, int slot_id, unsigned int ep_index)
		@@ -3843,10 +3861,7 @@ static int xhci_queue_isoc_tx(struct xhci_hcd *xhci, gfp_t mem_flags,
		more_trbs_coming = false;
		td->last_trb = ep_ring->enqueue;
		field \|= TRB_IOC;
		/* set BEI, except for the last TD */
		if (xhci->hci_version >= 0x100 &&
		!(xhci->quirks & XHCI_AVOID_BEI) &&
		i < num_tds - 1)
		if (trb_block_event_intr(xhci, num_tds, i))
		field \|= TRB_BEI;
		}
		/* Calculate TRB length */

Admin message