[SCSI] aacraid: remove unneeded locking (edb527ce) · Commits · 戴 / test

Received From Mark Salyzyn Since new commands to the card are quiesced, respect the changes in the SCSI error path which dropped locking around the hba reset handler and similarly drop the lock requirement in the driver's path. Signed-off-by:

Mark Haverkamp <markh@osdl.org> Signed-off-by:

James Bottomley <James.Bottomley@SteelEye.com>

drivers/scsi/aacraid/linit.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -453,15 +453,10 @@ static int aac_eh_reset(struct scsi_cmnd* cmd)

		printk(KERN_ERR "%s: Host adapter reset request. SCSI hang ?\n",
		AAC_DRIVERNAME);


		spin_lock_irq(host->host_lock);

		aac = (struct aac_dev *)host->hostdata;
		if (aac_adapter_check_health(aac)) {
		printk(KERN_ERR "%s: Host adapter appears dead\n",
		AAC_DRIVERNAME);
		spin_unlock_irq(host->host_lock);
		return -ENODEV;
		}
		/*
		@@ -487,13 +482,10 @@ static int aac_eh_reset(struct scsi_cmnd* cmd)
		/*
		* We can exit If all the commands are complete
		*/
		spin_unlock_irq(host->host_lock);
		if (active == 0)
		return SUCCESS;
		ssleep(1);
		spin_lock_irq(host->host_lock);
		}
		spin_unlock_irq(host->host_lock);
		printk(KERN_ERR "%s: SCSI bus appears hung\n", AAC_DRIVERNAME);
		return -ETIMEDOUT;
		}

Admin message