Commit eda6bc27 authored Nov 27, 2017 by Eric Sandeen Committed by Darrick J. Wong Nov 28, 2017

xfs: fix uninitialized variable in xfs_scrub_quota



On the first pass through the while(1) loop, we get to
xfs_scrub_should_terminate() which can test the uninitialized
error variable.

Fixes-coverity-id: 1423737
Fixes: c2fc338c ("xfs: scrub quota information")
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent d41c6172

fs/xfs/scrub/quota.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -207,7 +207,7 @@ xfs_scrub_quota(
		xfs_dqid_t id = 0;
		uint dqtype;
		int nimaps;
		int error;
		int error = 0;

		if (!XFS_IS_QUOTA_RUNNING(mp) \|\| !XFS_IS_QUOTA_ON(mp))
		return -ENOENT;

Admin message