Commit ed9f3e25 authored by Douglas Gilbert's avatar Douglas Gilbert Committed by Martin K. Petersen
Browse files

scsi: scsi_debug: Implement PRE-FETCH commands 

Many disks implement the SCSI PRE-FETCH commands. One use case might be a
disk-to-disk compare, say between disks A and B. Then this sequence of
commands might be used: PRE-FETCH(from B, IMMED), READ(from A), VERIFY
(BYTCHK=1 on B with data returned from READ).  The PRE-FETCH (which returns
quickly due to the IMMED) fetches the data from the media into B's cache
which should speed the trailing VERIFY command. The next chunk of the
compare might be done in parallel, with A and B reversed.

The implementation tries to bring the specified range in main memory into
the cache(s) associated with this machine's CPU(s) using the
prefetch_range() function.

Link: https://lore.kernel.org/r/20200421151424.32668-7-dgilbert@interlog.com


Signed-off-by: default avatarDouglas Gilbert <dgilbert@interlog.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent a2aede97

drivers/scsi/scsi_debug.c

+70 −5
Original line number Diff line number Diff line
@@ -41,6 +41,7 @@ 
#include <linux/msdos_partition.h>

#include <linux/random.h>

#include <linux/xarray.h>

#include <linux/prefetch.h>



#include <net/checksum.h>
@@ -367,7 +368,8 @@ enum sdeb_opcode_index { 
	SDEB_I_WRITE_SAME = 26,		/* 10, 16 */

	SDEB_I_SYNC_CACHE = 27,		/* 10, 16 */

	SDEB_I_COMP_WRITE = 28,

	SDEB_I_LAST_ELEMENT = 29,	/* keep this last (previous + 1) */

	SDEB_I_PRE_FETCH = 29,		/* 10, 16 */

	SDEB_I_LAST_ELEM_P1 = 30,	/* keep this last (previous + 1) */

};
@@ -383,7 +385,7 @@ static const unsigned char opcode_ind_arr[256] = { 
/* 0x20; 0x20->0x3f: 10 byte cdbs */

	0, 0, 0, 0, 0, SDEB_I_READ_CAPACITY, 0, 0,

	SDEB_I_READ, 0, SDEB_I_WRITE, 0, 0, 0, 0, SDEB_I_VERIFY,

	0, 0, 0, 0, 0, SDEB_I_SYNC_CACHE, 0, 0,

	0, 0, 0, 0, SDEB_I_PRE_FETCH, SDEB_I_SYNC_CACHE, 0, 0,

	0, 0, 0, SDEB_I_WRITE_BUFFER, 0, 0, 0, 0,

/* 0x40; 0x40->0x5f: 10 byte cdbs */

	0, SDEB_I_WRITE_SAME, SDEB_I_UNMAP, 0, 0, 0, 0, 0,
@@ -399,7 +401,7 @@ static const unsigned char opcode_ind_arr[256] = { 
	0, 0, 0, 0, 0, SDEB_I_ATA_PT, 0, 0,

	SDEB_I_READ, SDEB_I_COMP_WRITE, SDEB_I_WRITE, 0,

	0, 0, 0, SDEB_I_VERIFY,

	0, SDEB_I_SYNC_CACHE, 0, SDEB_I_WRITE_SAME, 0, 0, 0, 0,

	SDEB_I_PRE_FETCH, SDEB_I_SYNC_CACHE, 0, SDEB_I_WRITE_SAME, 0, 0, 0, 0,

	0, 0, 0, 0, 0, 0, SDEB_I_SERV_ACT_IN_16, SDEB_I_SERV_ACT_OUT_16,

/* 0xa0; 0xa0->0xbf: 12 byte cdbs */

	SDEB_I_REPORT_LUNS, SDEB_I_ATA_PT, 0, SDEB_I_MAINT_IN,
@@ -446,6 +448,7 @@ static int resp_write_same_16(struct scsi_cmnd *, struct sdebug_dev_info *); 
static int resp_comp_write(struct scsi_cmnd *, struct sdebug_dev_info *);

static int resp_write_buffer(struct scsi_cmnd *, struct sdebug_dev_info *);

static int resp_sync_cache(struct scsi_cmnd *, struct sdebug_dev_info *);

static int resp_pre_fetch(struct scsi_cmnd *, struct sdebug_dev_info *);



static int sdebug_do_add_host(bool mk_new_store);

static int sdebug_add_host_helper(int per_host_idx);
@@ -544,11 +547,17 @@ static const struct opcode_info_t sync_cache_iarr[] = { 
	     0xff, 0xff, 0xff, 0xff, 0x3f, 0xc7} },	/* SYNC_CACHE (16) */

};



static const struct opcode_info_t pre_fetch_iarr[] = {

	{0, 0x90, 0, F_SYNC_DELAY | F_M_ACCESS, resp_pre_fetch, NULL,

	    {16,  0x2, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,

	     0xff, 0xff, 0xff, 0xff, 0x3f, 0xc7} },	/* PRE-FETCH (16) */

};





/* This array is accessed via SDEB_I_* values. Make sure all are mapped,

 * plus the terminating elements for logic that scans this table such as

 * REPORT SUPPORTED OPERATION CODES. */

static const struct opcode_info_t opcode_info_arr[SDEB_I_LAST_ELEMENT + 1] = {

static const struct opcode_info_t opcode_info_arr[SDEB_I_LAST_ELEM_P1 + 1] = {

/* 0 */

	{0, 0, 0, F_INV_OP | FF_RESPOND, NULL, NULL,	/* unknown opcodes */

	    {0,  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} },
@@ -640,8 +649,12 @@ static const struct opcode_info_t opcode_info_arr[SDEB_I_LAST_ELEMENT + 1] = { 
	{0, 0x89, 0, F_D_OUT | FF_MEDIA_IO, resp_comp_write, NULL,

	    {16,  0xf8, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0, 0,

	     0, 0xff, 0x3f, 0xc7} },		/* COMPARE AND WRITE */

	{ARRAY_SIZE(pre_fetch_iarr), 0x34, 0, F_SYNC_DELAY | F_M_ACCESS,

	    resp_pre_fetch, pre_fetch_iarr,

	    {10,  0x2, 0xff, 0xff, 0xff, 0xff, 0x3f, 0xff, 0xff, 0xc7, 0, 0,

	     0, 0, 0, 0} },			/* PRE-FETCH (10) */



/* 29 */

/* 30 */

	{0xff, 0, 0, 0, NULL, NULL,		/* terminating element */

	    {0,  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} },

};
@@ -756,6 +769,8 @@ static const int illegal_condition_result = 
static const int device_qfull_result =

	(DID_OK << 16) | (COMMAND_COMPLETE << 8) | SAM_STAT_TASK_SET_FULL;



static const int condition_met_result = SAM_STAT_CONDITION_MET;





/* Only do the extra work involved in logical block provisioning if one or

 * more of the lbpu, lbpws or lbpws10 parameters are given and we are doing
@@ -3674,6 +3689,56 @@ static int resp_sync_cache(struct scsi_cmnd *scp, 
	return res;

}



/*

 * Assuming the LBA+num_blocks is not out-of-range, this function will return

 * CONDITION MET if the specified blocks will/have fitted in the cache, and

 * a GOOD status otherwise. Model a disk with a big cache and yield

 * CONDITION MET. Actually tries to bring range in main memory into the

 * cache associated with the CPU(s).

 */

static int resp_pre_fetch(struct scsi_cmnd *scp,

			  struct sdebug_dev_info *devip)

{

	int res = 0;

	u64 lba;

	u64 block, rest = 0;

	u32 nblks;

	u8 *cmd = scp->cmnd;

	struct sdeb_store_info *sip = devip2sip(devip);

	rwlock_t *macc_lckp = sip ? &sip->macc_lck : &sdeb_fake_rw_lck;

	u8 *fsp = sip ? sip->storep : NULL;



	if (cmd[0] == PRE_FETCH) {	/* 10 byte cdb */

		lba = get_unaligned_be32(cmd + 2);

		nblks = get_unaligned_be16(cmd + 7);

	} else {			/* PRE-FETCH(16) */

		lba = get_unaligned_be64(cmd + 2);

		nblks = get_unaligned_be32(cmd + 10);

	}

	if (lba + nblks > sdebug_capacity) {

		mk_sense_buffer(scp, ILLEGAL_REQUEST, LBA_OUT_OF_RANGE, 0);

		return check_condition_result;

	}

	if (!fsp)

		goto fini;

	/* PRE-FETCH spec says nothing about LBP or PI so skip them */

	block = do_div(lba, sdebug_store_sectors);

	if (block + nblks > sdebug_store_sectors)

		rest = block + nblks - sdebug_store_sectors;



	/* Try to bring the PRE-FETCH range into CPU's cache */

	read_lock(macc_lckp);

	prefetch_range(fsp + (sdebug_sector_size * block),

		       (nblks - rest) * sdebug_sector_size);

	if (rest)

		prefetch_range(fsp, rest * sdebug_sector_size);

	read_unlock(macc_lckp);

fini:

	if (cmd[1] & 0x2)

		res = SDEG_RES_IMMED_MASK;

	return res | condition_met_result;

}



#define RL_BUCKET_ELEMS 8



/* Even though each pseudo target has a REPORT LUNS "well known logical unit"

CRA Git | Maintained and supported by SUSTech CRA and CCSE