Commit ed7fe551 authored Jul 04, 2019 by Colin Ian King Committed by Greg Kroah-Hartman Jul 25, 2019

usb: chipidea: udc: remove redundant assignment to variable retval



The variable retval is being initialized with a value that is never
read and it is being updated later with a new value. The
initialization is redundant and can be removed.  Also remove a blank
line.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20190704150341.759-1-colin.king@canonical.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6269e4c7

drivers/usb/chipidea/udc.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1746,12 +1746,11 @@ static int ci_udc_start(struct usb_gadget *gadget,
		struct usb_gadget_driver *driver)
		{
		struct ci_hdrc *ci = container_of(gadget, struct ci_hdrc, gadget);
		int retval = -ENOMEM;
		int retval;

		if (driver->disconnect == NULL)
		return -EINVAL;


		ci->ep0out->ep.desc = &ctrl_endpt_out_desc;
		retval = usb_ep_enable(&ci->ep0out->ep);
		if (retval)

Admin message