Commit ed6e4ef8 authored by Julian Anastasov's avatar Julian Anastasov Committed by David S. Miller
Browse files

netfilter: Fix ip_route_me_harder triggering ip_rt_bug 



	Avoid creating input routes with ip_route_me_harder.
It does not work for locally generated packets. Instead,
restrict sockets to provide valid saddr for output route (or
unicast saddr for transparent proxy). For other traffic
allow saddr to be unicast or local but if callers forget
to check saddr type use 0 for the output route.

	The resulting handling should be:

- REJECT TCP:
	- in INPUT we can provide addr_type = RTN_LOCAL but
	better allow rejecting traffic delivered with
	local route (no IP address => use RTN_UNSPEC to
	allow also RTN_UNICAST).
	- FORWARD: RTN_UNSPEC => allow RTN_LOCAL/RTN_UNICAST
	saddr, add fix to ignore RTN_BROADCAST and RTN_MULTICAST
	- OUTPUT: RTN_UNSPEC

- NAT, mangle, ip_queue, nf_ip_reroute: RTN_UNSPEC in LOCAL_OUT

- IPVS:
	- use RTN_LOCAL in LOCAL_OUT and FORWARD after SNAT
	to restrict saddr to be local

Signed-off-by: default avatarJulian Anastasov <ja@ssi.bg>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 353e5c9a

net/ipv4/netfilter.c

+22 −38
Original line number Diff line number Diff line
@@ -17,27 +17,28 @@ int ip_route_me_harder(struct sk_buff *skb, unsigned addr_type) 
	const struct iphdr *iph = ip_hdr(skb);

	struct rtable *rt;

	struct flowi4 fl4 = {};

	unsigned long orefdst;

	__be32 saddr = iph->saddr;

	__u8 flags = 0;

	unsigned int hh_len;

	unsigned int type;



	type = inet_addr_type(net, iph->saddr);

	if (skb->sk && inet_sk(skb->sk)->transparent)

		type = RTN_LOCAL;

	if (!skb->sk && addr_type != RTN_LOCAL) {

		if (addr_type == RTN_UNSPEC)

		addr_type = type;

			addr_type = inet_addr_type(net, saddr);

		if (addr_type == RTN_LOCAL || addr_type == RTN_UNICAST)

			flags |= FLOWI_FLAG_ANYSRC;

		else

			saddr = 0;

	}



	/* some non-standard hacks like ipt_REJECT.c:send_reset() can cause

	 * packets with foreign saddr to appear on the NF_INET_LOCAL_OUT hook.

	 */

	if (addr_type == RTN_LOCAL) {

	fl4.daddr = iph->daddr;

		if (type == RTN_LOCAL)

			fl4.saddr = iph->saddr;

	fl4.saddr = saddr;

	fl4.flowi4_tos = RT_TOS(iph->tos);

	fl4.flowi4_oif = skb->sk ? skb->sk->sk_bound_dev_if : 0;

	fl4.flowi4_mark = skb->mark;

		fl4.flowi4_flags = skb->sk ? inet_sk_flowi_flags(skb->sk) : 0;

	fl4.flowi4_flags = skb->sk ? inet_sk_flowi_flags(skb->sk) : flags;

	rt = ip_route_output_key(net, &fl4);

	if (IS_ERR(rt))

		return -1;
@@ -45,23 +46,6 @@ int ip_route_me_harder(struct sk_buff *skb, unsigned addr_type) 
	/* Drop old route. */

	skb_dst_drop(skb);

	skb_dst_set(skb, &rt->dst);

	} else {

		/* non-local src, find valid iif to satisfy

		 * rp-filter when calling ip_route_input. */

		fl4.daddr = iph->saddr;

		rt = ip_route_output_key(net, &fl4);

		if (IS_ERR(rt))

			return -1;



		orefdst = skb->_skb_refdst;

		if (ip_route_input(skb, iph->daddr, iph->saddr,

				   RT_TOS(iph->tos), rt->dst.dev) != 0) {

			dst_release(&rt->dst);

			return -1;

		}

		dst_release(&rt->dst);

		refdst_drop(orefdst);

	}



	if (skb_dst(skb)->error)

		return -1;

net/ipv4/netfilter/ipt_REJECT.c

+4 −10
Original line number Diff line number Diff line
@@ -40,7 +40,6 @@ static void send_reset(struct sk_buff *oldskb, int hook) 
	struct iphdr *niph;

	const struct tcphdr *oth;

	struct tcphdr _otcph, *tcph;

	unsigned int addr_type;



	/* IP header checks: fragment. */

	if (ip_hdr(oldskb)->frag_off & htons(IP_OFFSET))
@@ -55,6 +54,9 @@ static void send_reset(struct sk_buff *oldskb, int hook) 
	if (oth->rst)

		return;



	if (skb_rtable(oldskb)->rt_flags & (RTCF_BROADCAST | RTCF_MULTICAST))

		return;



	/* Check checksum */

	if (nf_ip_checksum(oldskb, hook, ip_hdrlen(oldskb), IPPROTO_TCP))

		return;
@@ -101,19 +103,11 @@ static void send_reset(struct sk_buff *oldskb, int hook) 
	nskb->csum_start = (unsigned char *)tcph - nskb->head;

	nskb->csum_offset = offsetof(struct tcphdr, check);



	addr_type = RTN_UNSPEC;

	if (hook != NF_INET_FORWARD

#ifdef CONFIG_BRIDGE_NETFILTER

	    || (nskb->nf_bridge && nskb->nf_bridge->mask & BRNF_BRIDGED)

#endif

	   )

		addr_type = RTN_LOCAL;



	/* ip_route_me_harder expects skb->dst to be set */

	skb_dst_set_noref(nskb, skb_dst(oldskb));



	nskb->protocol = htons(ETH_P_IP);

	if (ip_route_me_harder(nskb, addr_type))

	if (ip_route_me_harder(nskb, RTN_UNSPEC))

		goto free_nskb;



	niph->ttl	= ip4_dst_hoplimit(skb_dst(nskb));

CRA Git | Maintained and supported by SUSTech CRA and CCSE