Commit ed5a9270 authored Feb 01, 2006 by Randy Dunlap Committed by Linus Torvalds Feb 01, 2006

[PATCH] tpm_bios: needs more securityfs_ functions

tpm_bios.c needs securityfs_xyz() functions.

Does include/linux/security.h need stubs for these, or should
char/tpm/Makefile just be modified to say:

ifdef CONFIG_ACPI
ifdef CONFIG_SECURITY
	obj-$(CONFIG_TCG_TPM) += tpm_bios.o
endif
endif

drivers/char/tpm/tpm_bios.c:494: warning: implicit declaration of function 'securityfs_create_dir'
drivers/char/tpm/tpm_bios.c:494: warning: assignment makes pointer from integer without a cast
drivers/char/tpm/tpm_bios.c:499: warning: implicit declaration of function 'securityfs_create_file'
drivers/char/tpm/tpm_bios.c:501: warning: assignment makes pointer from integer without a cast
drivers/char/tpm/tpm_bios.c:508: warning: assignment makes pointer from integer without a cast
drivers/char/tpm/tpm_bios.c:523: warning: implicit declaration of function 'securityfs_remove'
*** Warning: "securityfs_create_file" [drivers/char/tpm/tpm_bios.ko] undefined!
*** Warning: "securityfs_create_dir" [drivers/char/tpm/tpm_bios.ko] undefined!
*** Warning: "securityfs_remove" [drivers/char/tpm/tpm_bios.ko] undefined!

There are also some gcc and sparse warnings that could be fixed.
(see http://www.xenotime.net/linux/doc/build-tpm.out

)

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Serge Hallyn <serue@us.ibm.com>
Cc: Greg KH <greg@kroah.com>
Cc: Kylene Jo Hall <kjhall@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 7ee26aa0

include/linux/security.h

+19 −0

Original line number	Diff line number	Diff line
		@@ -2617,6 +2617,25 @@ static inline int security_netlink_recv (struct sk_buff *skb)
		return cap_netlink_recv (skb);
		}

		static inline struct dentry securityfs_create_dir(const char name,
		struct dentry *parent)
		{
		return ERR_PTR(-ENODEV);
		}

		static inline struct dentry securityfs_create_file(const char name,
		mode_t mode,
		struct dentry *parent,
		void *data,
		struct file_operations *fops)
		{
		return ERR_PTR(-ENODEV);
		}

		static inline void securityfs_remove(struct dentry *dentry)
		{
		}

		#endif /* CONFIG_SECURITY */

		#ifdef CONFIG_SECURITY_NETWORK

Admin message