Commit ed32201e authored Sep 17, 2011 by Mitsuo Hayasaka Committed by Alex Elder Oct 11, 2011

xfs: Return -EIO when xfs_vn_getattr() failed



An attribute of inode can be fetched via xfs_vn_getattr() in XFS.
Currently it returns EIO, not negative value, when it failed.  As a
result, the system call returns not negative value even though an
error occured. The stat(2), ls and mv commands cannot handle this
error and do not work correctly.

This patch fixes this bug, and returns -EIO, not EIO when an error
is detected in xfs_vn_getattr().

Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>

parent eabbaf11

fs/xfs/xfs_iops.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -465,7 +465,7 @@ xfs_vn_getattr(
		trace_xfs_getattr(ip);

		if (XFS_FORCED_SHUTDOWN(mp))
		return XFS_ERROR(EIO);
		return -XFS_ERROR(EIO);

		stat->size = XFS_ISIZE(ip);
		stat->dev = inode->i_sb->s_dev;

Admin message