[CIFS] Do not log path names in lookup errors (ed2b9170) · Commits · 戴 / test

Andi Kleen noticed that we were logging access denied errors (which is noisy in the dmesg log, and not needed to be logged) and that we were logging path names on that an other errors (e.g. EIO) which we should not be doing. CC: Andi Kleen <ak@suse.de> Signed-off-by:

Steve French <sfrench@us.ibm.com>

fs/cifs/dir.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -517,12 +517,10 @@ cifs_lookup(struct inode parent_dir_inode, struct dentry direntry,
		d_add(direntry, NULL);
		/* if it was once a directory (but how can we tell?) we could do
		shrink_dcache_parent(direntry); */
		} else {
		cERROR(1, ("Error 0x%x on cifs_get_inode_info in lookup of %s",
		rc, full_path));
		/* BB special case check for Access Denied - watch security
		exposure of returning dir info implicitly via different rc
		if file exists or not but no access BB */
		} else if (rc != -EACCES) {
		cERROR(1, ("Unexpected lookup error %d", rc));
		/* We special case check for Access Denied - since that
		is a common return code */
		}

		kfree(full_path);

Admin message