Commit ecf3411a authored May 17, 2017 by Colin Ian King Committed by Steve French Jun 20, 2017

CIFS: check if pages is null rather than bv for a failed allocation



pages is being allocated however a null check on bv is being used
to see if the allocation failed. Fix this by checking if pages is
null.

Detected by CoverityScan, CID#1432974 ("Logically dead code")

Fixes: ccf7f408 ("CIFS: Add asynchronous context to support kernel AIO")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <smfrench@gmail.com>

parent 8a7b0d8e

fs/cifs/misc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -810,7 +810,7 @@ setup_aio_ctx_iter(struct cifs_aio_ctx ctx, struct iov_iter iter, int rw)

		if (!pages) {
		pages = vmalloc(max_pages * sizeof(struct page *));
		if (!bv) {
		if (!pages) {
		kvfree(bv);
		return -ENOMEM;
		}

Admin message