Commit ecf08dad authored Apr 29, 2018 by Anthoine Bourgeois Committed by Radim Krčmář May 05, 2018

KVM: x86: remove APIC Timer periodic/oneshot spikes



Since the commit "8003c9ae: add APIC Timer periodic/oneshot mode VMX
preemption timer support", a Windows 10 guest has some erratic timer
spikes.

Here the results on a 150000 times 1ms timer without any load:
	  Before 8003c9ae | After 8003c9ae
Max           1834us          |  86000us
Mean          1100us          |   1021us
Deviation       59us          |    149us
Here the results on a 150000 times 1ms timer with a cpu-z stress test:
	  Before 8003c9ae | After 8003c9ae
Max          32000us          | 140000us
Mean          1006us          |   1997us
Deviation      140us          |  11095us

The root cause of the problem is starting hrtimer with an expiry time
already in the past can take more than 20 milliseconds to trigger the
timer function.  It can be solved by forward such past timers
immediately, rather than submitting them to hrtimer_start().
In case the timer is periodic, update the target expiration and call
hrtimer_start with it.

v2: Check if the tsc deadline is already expired. Thank you Mika.
v3: Execute the past timers immediately rather than submitting them to
hrtimer_start().
v4: Rearm the periodic timer with advance_periodic_target_expiration() a
simpler version of set_target_expiration(). Thank you Paolo.

Cc: Mika Penttilä <mika.penttila@nextfour.com>
Cc: Wanpeng Li <kernellwp@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
8003c9ae ("KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX preemption timer support")
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

parent f3351c60

arch/x86/kvm/lapic.c

+20 −17

Original line number	Diff line number	Diff line
		@@ -1463,23 +1463,6 @@ static void start_sw_tscdeadline(struct kvm_lapic *apic)
		local_irq_restore(flags);
		}

		static void start_sw_period(struct kvm_lapic *apic)
		{
		if (!apic->lapic_timer.period)
		return;

		if (apic_lvtt_oneshot(apic) &&
		ktime_after(ktime_get(),
		apic->lapic_timer.target_expiration)) {
		apic_timer_expired(apic);
		return;
		}

		hrtimer_start(&apic->lapic_timer.timer,
		apic->lapic_timer.target_expiration,
		HRTIMER_MODE_ABS_PINNED);
		}

		static void update_target_expiration(struct kvm_lapic *apic, uint32_t old_divisor)
		{
		ktime_t now, remaining;
		@@ -1546,6 +1529,26 @@ static void advance_periodic_target_expiration(struct kvm_lapic *apic)
		apic->lapic_timer.period);
		}

		static void start_sw_period(struct kvm_lapic *apic)
		{
		if (!apic->lapic_timer.period)
		return;

		if (ktime_after(ktime_get(),
		apic->lapic_timer.target_expiration)) {
		apic_timer_expired(apic);

		if (apic_lvtt_oneshot(apic))
		return;

		advance_periodic_target_expiration(apic);
		}

		hrtimer_start(&apic->lapic_timer.timer,
		apic->lapic_timer.target_expiration,
		HRTIMER_MODE_ABS_PINNED);
		}

		bool kvm_lapic_hv_timer_in_use(struct kvm_vcpu *vcpu)
		{
		if (!lapic_in_kernel(vcpu))

Admin message