Commit ecf081d1 authored by Eric Paris's avatar Eric Paris
Browse files

vfs: introduce FMODE_NONOTIFY 



This is a new f_mode which can only be set by the kernel.  It indicates
that the fd was opened by fanotify and should not cause future fanotify
events.  This is needed to prevent fanotify livelock.  An example of
obvious livelock is from fanotify close events.

Process A closes file1
This creates a close event for file1.
fanotify opens file1 for Listener X
Listener X deals with the event and closes its fd for file1.
This creates a close event for file1.
fanotify opens file1 for Listener X
Listener X deals with the event and closes its fd for file1.
This creates a close event for file1.
fanotify opens file1 for Listener X
Listener X deals with the event and closes its fd for file1.
notice a pattern?

The fix is to add the FMODE_NONOTIFY bit to the open filp done by the kernel
for fanotify.  Thus when that file is used it will not generate future
events.

This patch simply defines the bit.

Signed-off-by: default avatarEric Paris <eparis@redhat.com>
parent 35566087

include/asm-generic/fcntl.h

+8 −0
Original line number Diff line number Diff line
@@ -3,6 +3,14 @@ 


#include <linux/types.h>



/*

 * FMODE_EXEC is 0x20

 * FMODE_NONOTIFY is 0x800000

 * These cannot be used by userspace O_* until internal and external open

 * flags are split.

 * -Eric Paris

 */



#define O_ACCMODE	00000003

#define O_RDONLY	00000000

#define O_WRONLY	00000001

include/linux/fs.h

+5 −1
Original line number Diff line number Diff line
@@ -90,6 +90,9 @@ struct inodes_stat_t { 
/* Expect random access pattern */

#define FMODE_RANDOM		((__force fmode_t)0x1000)



/* File was opened by fanotify and shouldn't generate fanotify events */

#define FMODE_NONOTIFY		((__force fmode_t)8388608)



/*

 * The below are the various read and write types that we support. Some of

 * them include behavioral modifiers that send information down to the
@@ -2508,7 +2511,8 @@ int proc_nr_files(struct ctl_table *table, int write, 
int __init get_filesystem_list(char *buf);



#define ACC_MODE(x) ("\004\002\006\006"[(x)&O_ACCMODE])

#define OPEN_FMODE(flag) ((__force fmode_t)((flag + 1) & O_ACCMODE))

#define OPEN_FMODE(flag) ((__force fmode_t)(((flag + 1) & O_ACCMODE) | \

					    (flag & FMODE_NONOTIFY)))



#endif /* __KERNEL__ */

#endif /* _LINUX_FS_H */

include/linux/fsnotify.h

+16 −8
Original line number Diff line number Diff line
@@ -165,9 +165,11 @@ static inline void fsnotify_access(struct file *file) 
	if (S_ISDIR(inode->i_mode))

		mask |= FS_IN_ISDIR;



	if (!(file->f_mode & FMODE_NONOTIFY)) {

		fsnotify_parent(path, NULL, mask);

		fsnotify(inode, mask, path, FSNOTIFY_EVENT_PATH, NULL, 0);

	}

}



/*

 * fsnotify_modify - file was modified
@@ -181,9 +183,11 @@ static inline void fsnotify_modify(struct file *file) 
	if (S_ISDIR(inode->i_mode))

		mask |= FS_IN_ISDIR;



	if (!(file->f_mode & FMODE_NONOTIFY)) {

		fsnotify_parent(path, NULL, mask);

		fsnotify(inode, mask, path, FSNOTIFY_EVENT_PATH, NULL, 0);

	}

}



/*

 * fsnotify_open - file was opened
@@ -197,9 +201,11 @@ static inline void fsnotify_open(struct file *file) 
	if (S_ISDIR(inode->i_mode))

		mask |= FS_IN_ISDIR;



	if (!(file->f_mode & FMODE_NONOTIFY)) {

		fsnotify_parent(path, NULL, mask);

		fsnotify(inode, mask, path, FSNOTIFY_EVENT_PATH, NULL, 0);

	}

}



/*

 * fsnotify_close - file was closed
@@ -214,9 +220,11 @@ static inline void fsnotify_close(struct file *file) 
	if (S_ISDIR(inode->i_mode))

		mask |= FS_IN_ISDIR;



	if (!(file->f_mode & FMODE_NONOTIFY)) {

		fsnotify_parent(path, NULL, mask);

		fsnotify(inode, mask, path, FSNOTIFY_EVENT_PATH, NULL, 0);

	}

}



/*

 * fsnotify_xattr - extended attributes were changed

CRA Git | Maintained and supported by SUSTech CRA and CCSE