Commit ecde8f36 authored Apr 04, 2017 by Yuchung Cheng Committed by David S. Miller Apr 05, 2017

tcp: fix lost retransmit SNMP under-counting



The lost retransmit SNMP stat is under-counting retransmission
that uses segment offloading. This patch fixes that so all
retransmission related SNMP counters are consistent.

Fixes: 10d3be56 ("tcp-tso: do not split TSO packets at retransmit time")
Signed-off-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3ebfdf08

net/ipv4/tcp_recovery.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -12,7 +12,8 @@ static void tcp_rack_mark_skb_lost(struct sock sk, struct sk_buff skb)
		/* Account for retransmits that are lost again */
		TCP_SKB_CB(skb)->sacked &= ~TCPCB_SACKED_RETRANS;
		tp->retrans_out -= tcp_skb_pcount(skb);
		NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPLOSTRETRANSMIT);
		NET_ADD_STATS(sock_net(sk), LINUX_MIB_TCPLOSTRETRANSMIT,
		tcp_skb_pcount(skb));
		}
		}

Admin message