Commit ecd29dab authored by Vardan Mikayelyan's avatar Vardan Mikayelyan Committed by Felipe Balbi
Browse files

usb: dwc2: pci: Handle error cleanup in probe 



The probe function doesn't properly handle errors. Fix it so that it
properly handles cleanup.

Acked-by: default avatarJohn Youn <johnyoun@synopsys.com>
Signed-off-by: default avatarVardan Mikayelyan <mvardan@synopsys.com>
Signed-off-by: default avatarJohn Youn <johnyoun@synopsys.com>
Signed-off-by: default avatarGrigor Tovmasyan <tovmasya@synopsys.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent fb50aacd

drivers/usb/dwc2/pci.c

+3 −3
Original line number Original line Diff line number Diff line
@@ -114,7 +114,7 @@ static int dwc2_pci_probe(struct pci_dev *pci, 
	dwc2 = platform_device_alloc("dwc2", PLATFORM_DEVID_AUTO);

	dwc2 = platform_device_alloc("dwc2", PLATFORM_DEVID_AUTO);

	if (!dwc2) {

	if (!dwc2) {

		dev_err(dev, "couldn't allocate dwc2 device\n");

		dev_err(dev, "couldn't allocate dwc2 device\n");

		return -ENOMEM;

		goto err;

	}

	}





	memset(res, 0x00, sizeof(struct resource) * ARRAY_SIZE(res));

	memset(res, 0x00, sizeof(struct resource) * ARRAY_SIZE(res));
@@ -131,7 +131,7 @@ static int dwc2_pci_probe(struct pci_dev *pci, 
	ret = platform_device_add_resources(dwc2, res, ARRAY_SIZE(res));

	ret = platform_device_add_resources(dwc2, res, ARRAY_SIZE(res));

	if (ret) {

	if (ret) {

		dev_err(dev, "couldn't add resources to dwc2 device\n");

		dev_err(dev, "couldn't add resources to dwc2 device\n");

		return ret;

		goto err;

	}

	}





	dwc2->dev.parent = dev;

	dwc2->dev.parent = dev;
@@ -142,7 +142,7 @@ static int dwc2_pci_probe(struct pci_dev *pci, 




	glue = devm_kzalloc(dev, sizeof(*glue), GFP_KERNEL);

	glue = devm_kzalloc(dev, sizeof(*glue), GFP_KERNEL);

	if (!glue)

	if (!glue)

		return -ENOMEM;

		goto err;





	ret = platform_device_add(dwc2);

	ret = platform_device_add(dwc2);

	if (ret) {

	if (ret) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE