Commit ecd16650 authored Mar 05, 2012 by Jiri Slaby Committed by Greg Kroah-Hartman Mar 08, 2012

TTY: remove tty driver re-set from tty_reopen



This is from tty_reopen:
    struct tty_driver *driver = tty->driver;
    ...
    tty->driver = driver;
and it doesn't make sense at all. The driver is intended to be set in
initialize_tty_struct from tty_init_dev (initial open). So this set in
tty_reopen is not needed.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d4834267

drivers/tty/tty_io.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1348,7 +1348,6 @@ static int tty_reopen(struct tty_struct *tty)
		tty->link->count++;
		}
		tty->count++;
		tty->driver = driver; /* N.B. why do this every time?? */

		mutex_lock(&tty->ldisc_mutex);
		WARN_ON(!test_bit(TTY_LDISC, &tty->flags));

Admin message