Commit ecbcd324 authored Mar 29, 2010 by Jouni Malinen Committed by John W. Linville Mar 31, 2010

mac80211: Fix BIP to be used only with group-addressed frames



BIP (part of IEEE 802.11w) is only supposed to be used with
group-addressed frames. We ended up picking it as a default mechanism
for every management whenever we did not have a STA entry for the
destination (e.g., for Probe Response to a STA that is not
associated). While the extra MMIE in the end of management frames
should not break frames completed in most cases, there is no point in
doing this. Fix key selection to pick the default management key only
if the frame is sent to multicast/broadcast address and the frame is a
robust management frame.

Signed-off-by: Jouni Malinen <j@w1.fi>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent e69e95db

net/mac80211/tx.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -513,6 +513,8 @@ ieee80211_tx_h_select_key(struct ieee80211_tx_data *tx)
		else if (tx->sta && (key = rcu_dereference(tx->sta->key)))
		tx->key = key;
		else if (ieee80211_is_mgmt(hdr->frame_control) &&
		is_multicast_ether_addr(hdr->addr1) &&
		ieee80211_is_robust_mgmt_frame(hdr) &&
		(key = rcu_dereference(tx->sdata->default_mgmt_key)))
		tx->key = key;
		else if ((key = rcu_dereference(tx->sdata->default_key)))

Admin message