tcp: fix comment for tp->highest_sack (ecb97192) · Commits · 戴 / test

There was an off-by-one error in the comments describing the highest_sack field in struct tcp_sock. The comments previously claimed that it was the "start sequence of the highest skb with SACKed bit". This commit fixes the comments to note that it is the "start sequence of the skb just *after* the highest skb with SACKed bit". Signed-off-by:

Neal Cardwell <ncardwell@google.com> Acked-by:

Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> Signed-off-by:

David S. Miller <davem@davemloft.net>

include/linux/tcp.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -412,7 +412,8 @@ struct tcp_sock {

		struct tcp_sack_block recv_sack_cache[4];

		struct sk_buff highest_sack; / highest skb with SACK received
		struct sk_buff highest_sack; / skb just after the highest
		* skb with SACKed bit set
		* (validity guaranteed only if
		* sacked_out > 0)
		*/

include/net/tcp.h

+3 −2

Original line number	Diff line number	Diff line
		@@ -1364,8 +1364,9 @@ static inline void tcp_push_pending_frames(struct sock *sk)
		}
		}

		/* Start sequence of the highest skb with SACKed bit, valid only if
		* sacked > 0 or when the caller has ensured validity by itself.
		/* Start sequence of the skb just after the highest skb with SACKed
		* bit, valid only if sacked_out > 0 or when the caller has ensured
		* validity by itself.
		*/
		static inline u32 tcp_highest_sack_seq(struct tcp_sock *tp)
		{

Admin message