Commit ecaf8e52 authored Jun 13, 2011 by Steven Rostedt Committed by Steven Rostedt Jun 13, 2011

ktest: Have wait on stdio honor bug timeout



After a bug is found, the STOP_AFTER_FAILURE timeout is used to
determine how much output should be printed before breaking out
of the monitor loop. This is to get things like call traces and
enough infromation about the bug to help determine what caused it.

The STOP_AFTER_FAILURE is usually much shorter than the TIMEOUT
that is used to determine when to quit after no more stdio is given.

But since the stdio read uses a wait on I/O, the STOP_AFTER_FAILURE is
only checked after we get something from I/O. But if the I/O does
not return any more data, we wait the TIMEOUT period instead, even
though we already triggered a bug report.

The wait on I/O should honor the STOP_AFTER_FAILURE time if a bug has
been found.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

parent fcb3f16a

tools/testing/ktest/ktest.pl

+10 −1

Original line number	Diff line number	Diff line
		@@ -851,7 +851,16 @@ sub monitor {

		while (!$done) {

		if ($booted) {
		if ($bug && defined($stop_after_failure) &&
		$stop_after_failure >= 0) {
		my $time = $stop_after_failure - (time - $failure_start);
		$line = wait_for_input($monitor_fp, $time);
		if (!defined($line)) {
		doprint "bug timed out after $booted_timeout seconds\n";
		doprint "Test forced to stop after $stop_after_failure seconds after failure\n";
		last;
		}
		} elsif ($booted) {
		$line = wait_for_input($monitor_fp, $booted_timeout);
		if (!defined($line)) {
		my $s = $booted_timeout == 1 ? "" : "s";

Admin message