Commit ecaa3bda authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

TTY: ipwireless, fix tty->index handling 



* do not test if tty->index is in bounds. It is always.
* tty->index is not a minor! Fix that.

>From now on, let's assume that the parameter of the function is tty
index with base being zero. This makes also the code more readable.

Factually, there is no real change as tty_driver->minor_start is zero,
so the tests are equivalent. But it did not make sense. And if this
had changed eventually, it would have caused troubles.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Acked-by: default avatarJiri Kosina <jkosina@suse.cz>
Cc: David Sterba <dsterba@suse.cz>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 410235fd

drivers/tty/ipwireless/tty.c

+13 −23
Original line number Diff line number Diff line
@@ -90,33 +90,23 @@ static void report_deregistering(struct ipw_tty *tty) 
	       tty->index);

}



static struct ipw_tty *get_tty(int minor)

static struct ipw_tty *get_tty(int index)

{

	if (minor < ipw_tty_driver->minor_start

			|| minor >= ipw_tty_driver->minor_start +

			IPWIRELESS_PCMCIA_MINORS)

		return NULL;

	else {

		int minor_offset = minor - ipw_tty_driver->minor_start;



	/*

	 * The 'ras_raw' channel is only available when 'loopback' mode

	 * is enabled.

	 * Number of minor starts with 16 (_RANGE * _RAS_RAW).

	 */

		if (!ipwireless_loopback &&

				minor_offset >=

	if (!ipwireless_loopback && index >=

			 IPWIRELESS_PCMCIA_MINOR_RANGE * TTYTYPE_RAS_RAW)

		return NULL;



		return ttys[minor_offset];

	}

	return ttys[index];

}



static int ipw_open(struct tty_struct *linux_tty, struct file *filp)

{

	int minor = linux_tty->index;

	struct ipw_tty *tty = get_tty(minor);

	struct ipw_tty *tty = get_tty(linux_tty->index);



	if (!tty)

		return -ENODEV;
@@ -510,7 +500,7 @@ static int add_tty(int j, 
		ipwireless_associate_network_tty(network,

						 secondary_channel_idx,

						 ttys[j]);

	if (get_tty(j + ipw_tty_driver->minor_start) == ttys[j])

	if (get_tty(j) == ttys[j])

		report_registering(ttys[j]);

	return 0;

}
@@ -570,7 +560,7 @@ void ipwireless_tty_free(struct ipw_tty *tty) 


		if (ttyj) {

			mutex_lock(&ttyj->ipw_tty_mutex);

			if (get_tty(j + ipw_tty_driver->minor_start) == ttyj)

			if (get_tty(j) == ttyj)

				report_deregistering(ttyj);

			ttyj->closing = 1;

			if (ttyj->linux_tty != NULL) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE