platform/x86: intel_cht_int33fe: Drop double check for ACPI companion device (eca6f176) · Commits · 戴 / test

acpi_dev_get_resources() does perform the NULL pointer check against ACPI companion device which is given as function parameter. Thus, there is no need to duplicate this check in the caller. Signed-off-by:

Andy Shevchenko <andriy.shevchenko@linux.intel.com>

drivers/platform/x86/intel_cht_int33fe_common.c

+6 −8

Original line number	Diff line number	Diff line
		@@ -29,18 +29,16 @@ static int cht_int33fe_i2c_res_filter(struct acpi_resource ares, void data)

		static int cht_int33fe_count_i2c_clients(struct device *dev)
		{
		struct acpi_device *adev;
		struct acpi_device *adev = ACPI_COMPANION(dev);
		LIST_HEAD(resource_list);
		int count = 0;
		int ret;

		adev = ACPI_COMPANION(dev);
		if (!adev)
		return -EINVAL;

		acpi_dev_get_resources(adev, &resource_list,
		ret = acpi_dev_get_resources(adev, &resource_list,
		cht_int33fe_i2c_res_filter, &count);

		acpi_dev_free_resource_list(&resource_list);
		if (ret < 0)
		return ret;

		return count;
		}

Admin message